Skip to content

Fix label actor role evidence#14

Open
MkDev11 wants to merge 3 commits intoentrius:testfrom
MkDev11:fix/issue-13-label-actor-role-evidence
Open

Fix label actor role evidence#14
MkDev11 wants to merge 3 commits intoentrius:testfrom
MkDev11:fix/issue-13-label-actor-role-evidence

Conversation

@MkDev11
Copy link
Copy Markdown

@MkDev11 MkDev11 commented May 8, 2026

Summary

Fix label actor role attribution so stored maintainer review and comment evidence can resolve label actors.

Root cause: contributor_repo_roles only used PR and issue authors, while the service already stores GitHub association evidence on submitted reviews and issue/PR thread comments. Label actor views depend on contributor_repo_roles, so maintainers who reviewed or commented but did not author a PR/issue could appear with actor_association=null.

Changed behavior:

  • include submitted PR reviews in contributor role evidence
  • include issue/PR thread comments in contributor role evidence
  • keep latest known non-null association with deterministic tie-breaking
  • preserve the existing label API shape

Related Issues

Closes #13

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Testing

  • npm test
  • npm run lint
  • npm run build
  • npm run format:check
  • git diff --check
  • Temporary Postgres seed/query verification for reviewer/commenter label actor roles

Checklist

  • I have read the Contributing Guide
  • Code builds without errors
  • New and existing tests pass (if applicable)
  • Documentation updated (if applicable)
  • No unnecessary dependencies added

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 8, 2026
anderdc
anderdc requested changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@anderdc anderdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests

@MkDev11
Copy link
Copy Markdown
Author

MkDev11 commented May 8, 2026

Addressed: the PR already includes packages/das/src/db-view-contracts.spec.ts, and 4e6a412 adds prebuild: npm test so the existing Build workflow runs that regression suite before nest build. Local npm run build, npm run lint, and npm run format:check pass.

@MkDev11 MkDev11 requested a review from anderdc May 8, 2026 21:55
anderdc
anderdc requested changes May 10, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@anderdc anderdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo doesn't accept tests in contributor PRs. Drop packages/das/src/db-view-contracts.spec.ts and revert packages/das/package.json (remove the new test script and the prebuild: npm test line). The SQL view changes are fine — just strip the test additions.

@MkDev11
Copy link
Copy Markdown
Author

MkDev11 commented May 10, 2026

This repo doesn't accept tests in contributor PRs. Drop packages/das/src/db-view-contracts.spec.ts and revert packages/das/package.json (remove the new test script and the prebuild: npm test line). The SQL view changes are fine — just strip the test additions.

done

@MkDev11 MkDev11 requested a review from anderdc May 10, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anderdc anderdc Awaiting requested review from anderdc

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Label actor roles ignore stored maintainer review and comment evidence

2 participants

@MkDev11 @anderdc